<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<h3>
Arun Raghavan pushed to branch master
at <a href="https://gitlab.freedesktop.org/pulseaudio/pulseaudio">PulseAudio / pulseaudio</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/4d1e5686194d5c6671e3023b5e55a4043d6e1824">4d1e5686</a></strong>
<div>
<span>by Wim Taymans</span>
<i>at 2020-08-03T09:58:39+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">alsa-util: fix check for digit
Fix the check for a digit by checking if the value is between the
*character* '0' (not *value* 0) and '9'.
</pre>
</li>
</ul>
<h4>1 changed file:</h4>
<ul>
<li class="file-stats">
<a href="#3ac06ce22ce83ead012b5ee8edbdadc1e0bfa5cb">
src/modules/alsa/alsa-util.c
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id="3ac06ce22ce83ead012b5ee8edbdadc1e0bfa5cb">
<a href="https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/4d1e5686194d5c6671e3023b5e55a4043d6e1824#3ac06ce22ce83ead012b5ee8edbdadc1e0bfa5cb"><strong>src/modules/alsa/alsa-util.c</strong></a>
<hr>
<table class="code white" style="font-family: monospace; font-size: 90%;" bgcolor="#fff" width="100%" cellpadding="0" cellspacing="0">
<tr class="line_holder match" id="" style="line-height: 1.6;">
<td class="diff-line-num unfold js-unfold old_line" data-linenumber="1752" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">...</td>
<td class="diff-line-num unfold js-unfold new_line" data-linenumber="1752" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">...</td>
<td class="line_content match " style="padding-left: 0.5em; padding-right: 0.5em; color: rgba(0,0,0,0.3);" bgcolor="#fafafa">@@ -1752,7 +1752,7 @@ snd_mixer_t *pa_alsa_open_mixer_by_name(pa_hashmap *mixers, const char *dev, boo</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="1752" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1752
</td>
<td class="diff-line-num new_line" data-linenumber="1752" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1752
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1752" class="line" lang="c"> <span class="k" style="font-weight: 600;">if</span> <span class="p">(</span><span class="o" style="font-weight: 600;">!</span><span class="n" style="color: #333;">pm</span> <span class="o" style="font-weight: 600;">&&</span> <span class="n" style="color: #333;">pa_strneq</span><span class="p">(</span><span class="n" style="color: #333;">dev</span><span class="p">,</span> <span class="s" style="color: #d14;">"hw:"</span><span class="p">,</span> <span class="mi" style="color: #099;">3</span><span class="p">))</span> <span class="p">{</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="1753" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1753
</td>
<td class="diff-line-num new_line" data-linenumber="1753" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1753
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1753" class="line" lang="c"> <span class="k" style="font-weight: 600;">const</span> <span class="kt" style="color: #458; font-weight: 600;">char</span> <span class="o" style="font-weight: 600;">*</span><span class="n" style="color: #333;">s</span> <span class="o" style="font-weight: 600;">=</span> <span class="n" style="color: #333;">dev</span> <span class="o" style="font-weight: 600;">+</span> <span class="mi" style="color: #099;">3</span><span class="p">;</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="1754" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1754
</td>
<td class="diff-line-num new_line" data-linenumber="1754" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1754
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1754" class="line" lang="c"> <span class="kt" style="color: #458; font-weight: 600;">int</span> <span class="n" style="color: #333;">card_index</span><span class="p">;</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="" style="line-height: 1.6;">
<td class="diff-line-num old old_line" data-linenumber="1755" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
1755
</td>
<td class="diff-line-num new_line old" data-linenumber="1755" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC1755" class="line" lang="c"> <span class="k" style="font-weight: 600;">while</span> <span class="p">(</span><span class="o" style="font-weight: 600;">*</span><span class="n" style="color: #333;">s</span> <span class="o" style="font-weight: 600;">&&</span> <span class="o" style="font-weight: 600;">*</span><span class="n" style="color: #333;">s</span> <span class="o" style="font-weight: 600;">>=</span> <span class="mi" style="color: #099;"><span class="idiff left right">0</span></span> <span class="o" style="font-weight: 600;">&&</span> <span class="o" style="font-weight: 600;">*</span><span class="n" style="color: #333;">s</span> <span class="o" style="font-weight: 600;"><=</span> <span class="sc" style="color: #d14;">'9'</span><span class="p">)</span> <span class="n" style="color: #333;">s</span><span class="o" style="font-weight: 600;">++</span><span class="p">;</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="" style="line-height: 1.6;">
<td class="diff-line-num new old_line" data-linenumber="1756" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="1755" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
1755
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC1755" class="line" lang="c"> <span class="k" style="font-weight: 600;">while</span> <span class="p">(</span><span class="o" style="font-weight: 600;">*</span><span class="n" style="color: #333;">s</span> <span class="o" style="font-weight: 600;">&&</span> <span class="o" style="font-weight: 600;">*</span><span class="n" style="color: #333;">s</span> <span class="o" style="font-weight: 600;">>=</span> <span class="sc" style="color: #d14;"><span class="idiff left right">'0'</span></span> <span class="o" style="font-weight: 600;">&&</span> <span class="o" style="font-weight: 600;">*</span><span class="n" style="color: #333;">s</span> <span class="o" style="font-weight: 600;"><=</span> <span class="sc" style="color: #d14;">'9'</span><span class="p">)</span> <span class="n" style="color: #333;">s</span><span class="o" style="font-weight: 600;">++</span><span class="p">;</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="1756" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1756
</td>
<td class="diff-line-num new_line" data-linenumber="1756" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1756
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1756" class="line" lang="c"> <span class="k" style="font-weight: 600;">if</span> <span class="p">(</span><span class="o" style="font-weight: 600;">*</span><span class="n" style="color: #333;">s</span> <span class="o" style="font-weight: 600;">==</span> <span class="sc" style="color: #d14;">'\0'</span> <span class="o" style="font-weight: 600;">&&</span> <span class="n" style="color: #333;">pa_atoi</span><span class="p">(</span><span class="n" style="color: #333;">dev</span> <span class="o" style="font-weight: 600;">+</span> <span class="mi" style="color: #099;">3</span><span class="p">,</span> <span class="o" style="font-weight: 600;">&</span><span class="n" style="color: #333;">card_index</span><span class="p">)</span> <span class="o" style="font-weight: 600;">>=</span> <span class="mi" style="color: #099;">0</span><span class="p">)</span> <span class="p">{</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="1757" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1757
</td>
<td class="diff-line-num new_line" data-linenumber="1757" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1757
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1757" class="line" lang="c"> <span class="n" style="color: #333;">PA_HASHMAP_FOREACH_KV</span><span class="p">(</span><span class="n" style="color: #333;">dev2</span><span class="p">,</span> <span class="n" style="color: #333;">pm</span><span class="p">,</span> <span class="n" style="color: #333;">mixers</span><span class="p">,</span> <span class="n" style="color: #333;">state</span><span class="p">)</span> <span class="p">{</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="1758" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1758
</td>
<td class="diff-line-num new_line" data-linenumber="1758" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1758
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1758" class="line" lang="c"> <span class="k" style="font-weight: 600;">if</span> <span class="p">(</span><span class="n" style="color: #333;">pm</span><span class="o" style="font-weight: 600;">-></span><span class="n" style="color: #333;">card_index</span> <span class="o" style="font-weight: 600;">==</span> <span class="n" style="color: #333;">card_index</span><span class="p">)</span> <span class="p">{</span></span>
</pre>
</td>
</tr>
</table>
<br>
</li>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
<a href="https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/4d1e5686194d5c6671e3023b5e55a4043d6e1824">View it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.freedesktop.org.
If you'd like to receive fewer emails, you can
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Commit","url":"https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/4d1e5686194d5c6671e3023b5e55a4043d6e1824"}}</script>
</p>
</div>
</body>
</html>