[pulseaudio-discuss] Export pulsecore and pulsecommon header file

[Zhang, Xing Z]

Hi Lennart:
	What's your opinion?

Zhang Xin(Wing)
Intel(SSG/OTC) ShangHai China 

>-----Original Message-----
>From: pulseaudio-discuss-bounces at mail.0pointer.de [mailto:pulseaudio-
>discuss-bounces at mail.0pointer.de] On Behalf Of Zhang, Xing Z
>Sent: 2009年4月13日 10:09
>To: General PulseAudio Discussion
>Subject: Re: [pulseaudio-discuss] Export pulsecore and pulsecommon header
>file
>
>Hi Lennart:
>	I noticed that before. The disadvantage is there will be many hard
>coding paths. If you create a new directory in src/module, a new xxx_HEADER
>must be added in line with the changing. My patch dynamically parses
>subdirectories to avoid these hard coding works.
>	Feel free to let me know if you prefer xxx_HEADER pattern. I would
>align to your suggestion.
>
>Zhang Xin(Wing)
>Intel(SSG/OTC) ShangHai China
>
>>-----Original Message-----
>>From: pulseaudio-discuss-bounces at mail.0pointer.de [mailto:pulseaudio-
>>discuss-bounces at mail.0pointer.de] On Behalf Of Lennart Poettering
>>Sent: 2009年4月11日 7:57
>>To: pulseaudio-discuss at mail.0pointer.de
>>Subject: Re: [pulseaudio-discuss] Export pulsecore and pulsecommon header
>>file
>>
>>On Wed, 08.04.09 09:43, Zhang, Xing Z (xing.z.zhang at intel.com) wrote:
>>
>>>
>>>
>>> >
>>> >On Tue, 07.04.09 15:25, Colin Guthrie (gmane at colin.guthr.ie) wrote:
>>> >
>>> >>
>>> >> 'Twas brillig, and Lennart Poettering at 07/04/09 13:56 did gyre and
>>> >gimble:
>>> >>> On Tue, 07.04.09 16:19, Zhang, Xing Z (xing.z.zhang at intel.com) wrote:
>>> >>>
>>> >>>> Hi Lennart:
>>> >>>> 	Could you have some comments on this patch
>>> >>>
>>> >>> See no patch! Did you forget to attach it?
>>> >>
>>> >> It was in the previous message on the thread:
>>> >>
>>> >> <http://permalink.gmane.org/gmane.comp.audio.pulseaudio.general/3098>
>>> >
>>> >Ah, ok. somehow i missed that.
>>> >
>>> >Zhang, what is the reason for doing your own install-pulse-headers
>>> >targets? Why not just add them to some form of standard automake
>>> >_HEADERS?
>>>
>>> It is for making module developed by installed headers can be easily
>>merged to upstream.
>>> With standard automake HEADERS all headers will be located at one
>>directory(eg. /usr/include/pulse_xxx/), programmers may arrange their
>files
>>as below pattern:
>>> #include <core.h>
>>
>>Uh, that's a misconception. You can easily have different install
>>directories by using different prefixes to HEADERS. i.e. right now we have:
>>
>>pulseincludedir=$(includedir)/pulse
>>pulseinclude_HEADERS = ....
>>
>>You could easily add more, such as:
>>
>>pulsecoreincludedir=$(includedir)/pulsecore
>>pulsecoreinclude_HEADERS = ....
>>
>>Or suchlike.
>>
>>Lennart
>>
>>--
>>Lennart Poettering                        Red Hat, Inc.
>>lennart [at] poettering [dot] net         ICQ# 11060553
>>http://0pointer.net/lennart/           GnuPG 0x1A015CC4
>>_______________________________________________
>>pulseaudio-discuss mailing list
>>pulseaudio-discuss at mail.0pointer.de
>>https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
>_______________________________________________
>pulseaudio-discuss mailing list
>pulseaudio-discuss at mail.0pointer.de
>https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss