[pulseaudio-discuss] [PATCH] Do not use tsched watermark if tsched is disabled

[Colin Guthrie]

'Twas brillig, and Colin Guthrie at 17/08/10 19:03 did gyre and gimble:
> 'Twas brillig, and David Henningsson at 17/08/10 19:00 did gyre and gimble:
>> The tsched watermark variable was incorrectly used even for sinks
>> with timer scheduling disabled, causing XRUNs on every rewind. This
>> patch sets a fixed margin of 20 msec for such rewinds, thus avoiding
>> the underrun.
>>
>> One could argue that the margin should be adjustable somehow (or based
>> on fragment-size, or something else), but this patch at least fixes the
>> immediate problem, causing "crackling" output on (at least) one machine.
> 
> /me wonders if this fixes
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=537378

Hmm, it seems to in my tests :)

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mandriva Linux Contributor [http://www.mandriva.com/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]