[pulseaudio-discuss] [PATCH] [module-loopback] Add PA_SOURCE_OUTPUT_DONT_MOVE flag of source-output to make the module-loopback unloading when the A2DP source ware unavailable

Colin Guthrie gmane at colin.guthr.ie
Wed Dec 22 01:23:42 PST 2010


'Twas brillig, and Cai Yuanqing at 22/12/10 06:25 did gyre and gimble:
> I wrote a patch to make the module-loopback unloading as bluetooth
> source was unavailable.
> 
> In my opinion ,moving the source of source-output from a live source
> like A2DP source to default or any other ones dose not work.only
> module-loopback loaded and can not work any more.
> So I just want to make the module-loopback can not be moved when the
> source is a A2DP source of bluetooth.


While this is Pierre-Louis Bossart's module and I'd like to hear his
opinion on it, I'm not personally a big fan of this kind of heuristic.

If you care to add a new argument to the module called e.g. "dont_move"
that adds in the appropriate flag to the sink input or source output,
then I think this would be a better and more deterministic behaviour. It
would obviously only make sense when used with the source= or sink=
arguments.

> BTW,I'm not sure that should we unload the modules when the source it
> using were unavailable in the other situations.
> Dose anyone have ideas for that?

I'm kind of of the same opinion. I prefer to see modules (and this
applies to others like remap, combine etc.) "idle" when their tightly
bound sink/sources are no longer available and then "kick in"
automatically when they appear. This kind of logic would allow for more
things to be added to a user's customised default.pa and automatically
work when appropriate.

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]




More information about the pulseaudio-discuss mailing list