[pulseaudio-discuss] regression in pacat

[Lennart Poettering]

On Thu, 18.02.10 09:05, Colin Guthrie (gmane at colin.guthr.ie) wrote:

> 
> 'Twas brillig, and Lennart Poettering at 18/02/10 00:59 did gyre and gimble:
> > On Wed, 17.02.10 23:57, Lennart Poettering (lennart at poettering.net) wrote:
> > 
> >>
> >> On Wed, 17.02.10 23:53, Lennart Poettering (lennart at poettering.net) wrote:
> >>
> >>>>>>>> So, yes, I actually meant what I did in fb55798a... Now the question
> >>>>>>>> is why this doesn't work for Pierre.
> >>>>>
> >>>>> Additional information:
> >>>>> - paplay <file.wav> does not start, the start callback isn't called
> >>>>
> >>>> Oh, indeed. I can reproduce this here. 
> >>>
> >>> Actually that was a false alarm. Doesn't actually happen here. The
> >>> .wav file I tested was simply very long.
> >>
> >> Nah, strike that. I actually can repriduce this now, for real.
> > 
> > OK, fixed now:
> > 
> > http://git.0pointer.de/?p=pulseaudio.git;a=patch;h=19fa81bf1375032cb1a27c7715a28a52b238d4cb
> 
> Nice! Should I revert the commit on git master? Or is it harmless?

I have reverted that now and cherry picked the fix from stable-queue.

> If I do revert, I'll have to fix the passing of the buffer attr to the
> recording stream as that's something I think you overlooked in the
> original. Happy to do that just need a nod from you.

Oh, indeed! Good catch. Fixed now too.

Lennart

-- 
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net
http://0pointer.net/lennart/           GnuPG 0x1A015CC4