[pulseaudio-discuss] [PATCH] rtkit: Add dbus properties for returning rttime-nsec-max, max-realtime-priority and min-nice-level

[David Henningsson]

> On Wed, 06.01.10 05:53, David Henningsson (launchpad.web at epost.diwic.se)
> wrote:
>
>> Thanks for the pointers, they were most helpful.
>>
>> First, RtKit version is 0.4-0ubuntu2, OS is Ubuntu 10.04 (the
>> development
>> version). If that matters.
>>
>> I had trouble getting rtkit-test succeeding at first, and a long story
>> short, I was likely affected by this bug:
>> http://www.spinics.net/lists/linux-fsdevel/msg28757.html
>> ...so I had to try an bleeding edge kernel, in which rtkit-test works.
>>
>> After some additional debugging, I found that my original problem was
>> that
>> the rt-priority I requested was too high for rtkit to accept. So the
>> permission problem comes from rtkit, the process_set_realtime() call
>> returns -EPERM. So an additional question: would it be possible to
>> either
>> detect that highest value rtkit can deliver, or say "hey, I want x, but
>> if
>> you only can give me y, do that instead of failing"? In worst case, I
>> could do a binary search, but I'm glad if that could be avoided :-)
>> The same would be nice for the maximum value of RLIMIT_RTTIME.
>
> Hmm, yes, I guess that would make sense indeed. Adding this as props
> should be very simple.

It wasn't that difficult even for a dbus newbie as myself. I took the
liberty of stealing a few lines from pulseaudio's reserve.c [1].

>> This is one of the things I love most about Linux/FOSS, the ability to
>> debug wherever you want. I ended up inserting some debug prints in
>> rtkit-daemon to nail the problem down - had rtkit been a Windows system
>> service delivered by Microsoft, I'd probably still be stuck!
>
> He. Free Software also lives from contributions. So if you want to see
> these properties added quickly, then prep a clean patch and I'll merge
> it. ;-)

Hopefully the patch attached will do the job and be clean enough for you!

// David

[1] You, Lennart, is the only copyright holder and it's BSD license. I
assume you don't mind :-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-dbus-properties-for-returning-rttime-nsec-max-ma.patch
Type: text/x-patch
Size: 4807 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20100117/2fbeefb0/attachment.bin>