[pulseaudio-discuss] [PATCH] Fix crash on jack server shutdown

[Colin Guthrie]

'Twas brillig, and David Henningsson at 14/03/10 19:50 did gyre and gimble:
> On sink unlinking, existing sink inputs are moved, which in turn calls
> a get latency callback, which references the jack client. Therefore,
> make sure the sink is unlinked before the client is closed. Failure to
> do so might lead to SIGSEGV.
> 
> This patch simply moves the call to pa_sink_unlink above
> jack_client_close, which fixes the problem.
> 
> Steps to reproduce:
> 
> 1. Disable autospawn and kill PA
> 2. Start jack server
> 3. Start PA
> 4. Load module module-jack-sink
> 5. Start a stream (e g Rythmbox) and run it through the jack sink.
> 6. Shutdown the jack server. Now PA crashes with SIGSEGV.

Cheers David. Looks good to me (tho' I'm no jack expert!) so pushed to
stable-queue. As with Daniel's patch the other day it'll go into master
too when I get some breathing space to merge the various outstanding
issue or when Lennart gets back from Bossa.

Cheers

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mandriva Linux Contributor [http://www.mandriva.com/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]