[pulseaudio-discuss] [PATCH] combine: Handle reappearing slave sinks in non-automatic mode.

Tanu Kaskinen tanu.kaskinen at digia.com
Fri Nov 12 04:36:25 PST 2010

On Fri, 2010-11-12 at 11:15 +0200, Colin Guthrie wrote:
>  * If no slaves exist, just idle and wait for the necessary hooks before
> loading the actual combine sink.
>  * If one of our "watched" slaves turns up, and we have not yet created
> our combine sink, then create it.
>  * If all our slaves disappear, unload our sink but keep the module
> loaded and go back to idling and waiting for sinks to appear again.

I guess that currently, when run in the "automatic" mode (i.e. without
any specified slaves), module-combine creates a sink that doesn't
process any data. Can you think of any situations where such dummy sink
can cause some harm, and where it would be better to unload the sink?

If the combined sink disappears when no slaves are around, I can imagine
that it might break some static configurations that assume that the
combined sink exists. Therefore I'd prefer leaving the combined sink
around. Without concrete examples this is a bit hand-wavy, but OTOH I'm
not aware of any downsides to having the combined sink always present.


More information about the pulseaudio-discuss mailing list