[pulseaudio-discuss] [PATCH] combine: Handle reappearing slave sinks in non-automatic mode.

[Colin Guthrie]

'Twas brillig, and Colin Guthrie at 17/11/10 23:41 did gyre and gimble:
> 'Twas brillig, and Antti-Ville Jansson at 17/11/10 11:45 did gyre and
> gimble:
>> On Tue, 2010-11-16 at 23:50 +0200, Colin Guthrie wrote:
>>> 'Twas brillig, and Antti-Ville Jansson at 12/11/10 10:26 did gyre and
>>> gimble:
>>>> The functionality you suggested sounds good, so I could give it a shot.
>>>> I can try to provide another patch sometime next week.
>>>>
>>>> In the meantime, you can merge this one if you see fit.
>>>
>>> OK, merged now :) Thanks!
>>
>>
>> Great, thanks!
>>
>> As for the suggested improvements, I probably won't (at least yet, due
>> to some technical reasons) be providing a patch for initializing the
>> combine module without slave sinks present. But thanks anyway for the
>> feedback.
> 
> Actually I'm doing a bit more testing and I think it's not working
> correctly :s
> 
> I tried:
> 
> [colin at jimmy pulseaudio]$ pactl load-module module-null-sink
> sink_name=foo sink_properties=device.description=Foo
> 25
> [colin at jimmy pulseaudio]$ pactl load-module module-null-sink
> sink_name=bar sink_properties=device.description=Bar
> 26
> [colin at jimmy pulseaudio]$ pactl load-module module-combine
> sink_name=oink sink_properties=device.description=Oink slaves=foo,bar
> 27
> 
> 
> I then did:
> 
> PULSE_SINK=oink paplay /usr/share/sounds/ia_ora-startup.wav
> 
> 
> I then removed the bar sink:
> 
> pactl unload-module 26
> 
> And everything worked as expected, but when I added the sink back in
> again, it was not added back into the combine sink.
> 
> I think this is because it fails the "is_suitable_sink()" test which IMO
> only makes sense in automatic mode. I'll fix that up :)

OK fixed in:

71cb35691ca0ea48dc559a69a554e02dd2ae30f5

Cheers

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]