[pulseaudio-discuss] [PATCH] core: New LIFO style flist implementation

[Colin Guthrie]

'Twas brillig, and Colin Guthrie at 16/11/10 21:50 did gyre and gimble:
> 'Twas brillig, and Colin Guthrie at 16/11/10 15:45 did gyre and gimble:
>> 'Twas brillig, and Jyri Sarha at 16/11/10 14:01 did gyre and gimble:
>>> Lennart would have time to take a look at it.
>>
>> Judging by past experience of the last 8 months or so, I suspect you
>> could be waiting a while for that.
>>
>> I've got a few patches queued up now, so I'll try and find time to purge
>> and test everything and push it. Better doing it this way and with
>> Lennart reverting it later if he has objections than it sitting and
>> bitrotting on the mailing list IMO :)
> 
> OK, pushed it now. If Lennart has any objections he'll have to revert
> it! Thanks for this.
> 
> I did make one very minor change. You removed Lennart's copyright
> completely but my git blame after applying did show some of his code
> still in use. It is mostly trivial but I think it's still necessary to
> keep it in there.
> 
> If you really disagree, I'd be more comfortable if Lennart himself
> removed it. Hope that's OK with you.

Not sure how "new" this issue is, or if this is just more debug than
before but after running pavucontrol, I get this:


I: client.c: Freed 1 "PulseAudio Volume Control"
W: flist.c: flist is full
W: flist.c: flist is full
W: flist.c: flist is full
W: flist.c: flist is full
W: flist.c: flist is full
W: flist.c: flist is full
W: flist.c: flist is full
W: flist.c: flist is full
W: flist.c: flist is full
W: flist.c: flist is full
I: protocol-native.c: Connection died.


There were a lot more flist is full messages after this too.

Running e.g. mplayer to produce sound did not seem to trigger this
problem, but running pavucontrol and exiting did (I didn't need to make
any changes in pavucontrol, just run it and exit).

Could you maybe have a look and see if you can reproduce (and
[optimistically] fix?)

Cheers

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]