[pulseaudio-discuss] [PATCH 0/5] Fix "flist is full" log spamming
oku at iki.fi
oku at iki.fi
Fri Nov 26 08:38:22 PST 2010
From: Jyri Sarha <jyri.sarha at nokia.com>
I forgot a spamming log message to the flist.c patch that was applied
a few days ago. This is an attempt to lower the annoyance level of that
The first patch lowers the log level for the message and adds ratelimit
The second patch adds name of the flist to the log message. To do that
it adds pa_flist_new_with_name() function which is used in
PA_STATIC_FLIST_DECLARE macro .
By adding a new function to libpulsecommon I hit very anoyng build
problems. In Makefile.am many binaries are only linked to libpulse but
not to libpulsecommon. This works as long as there is a close enough
libpulsecommon version installed in the system, but when you add a new
function to libpulsecommon things fall a part.
To fix this I made the third patch. This fix is kind of unfortunate,
because it ties pulseaudio client tightly to libpulsecommon version.
But I guess that is not too serious since most clients are already
linking directly to libpulsecommon. If you don't agree with my solution
just leave this one out.
The fourth patch fixes a reverse of the previous problem. IOW, if you
try to compile an older source tree and the one installed in your system
the binaries (test binaries mostly) linking only to libpulsecommon will
find newer version of libpulse which may expect non existing symbols
from currently built libpulsecommon.
The last patch puts LIRC_LIBS last on LIBADD line. This avoids problem
when you have an older version pulseaudio libs installed under /usr/lib
and you are building a newer version with some other directory prefix.
The LIRC_LIBS before PA-libs puts -L/usr/lib before -L$(libdir) on
relink (=install) phase, which is bad.
Jyri Sarha (5):
core: Lower "flist is full" log message level to debug and ratelimit
core: Add name to flist struct for more informative log messages
src/Makefile.am: Link binaries linking libpulse to libpulsecommon too
src/Makefile.am: Link binaries linking libpulsecommon to libpulse too
src/Makefile.am: Link lirc libraries in right order
src/Makefile.am | 82 ++++++++++++++++++++++++------------------------
src/pulsecore/flist.c | 11 +++++-
src/pulsecore/flist.h | 7 +++-
3 files changed, 55 insertions(+), 45 deletions(-)
More information about the pulseaudio-discuss