[pulseaudio-discuss] [PATCH] bluetooth: Add support for Media API

[Luiz Augusto von Dentz]

Hi,

On Wed, Oct 13, 2010 at 11:40 AM, Colin Guthrie <gmane at colin.guthr.ie> wrote:
> 'Twas brillig, and Colin Guthrie at 11/10/10 14:05 did gyre and gimble:
>> 'Twas brillig, and Luiz Augusto von Dentz at 11/10/10 13:45 did gyre and
>> gimble:
>>> The following changes since commit 3de129f3ac8dd6cf51178b266837db4d5e4a1215:
>>>
>>>   introspect: Include whether a stream is corked in the info callback.
>>> (2010-10-06 09:17:01 +0100)
>>>
>>> are available in the git repository at:
>>>   git://gitorious.org/~vudentz/pulseaudio/vudentzs-clone.git master
>>>
>>> Luiz Augusto von Dentz (1):
>>>       bluetooth: Add support for Media API
>>>
>>>  src/modules/bluetooth/bluetooth-util.c          |  666 ++++++++++++++++++++++-
>>>  src/modules/bluetooth/bluetooth-util.h          |   26 +
>>>  src/modules/bluetooth/ipc.h                     |   28 +
>>>  src/modules/bluetooth/module-bluetooth-device.c |  461 ++++++++++++++--
>>>  4 files changed, 1109 insertions(+), 72 deletions(-)
>>>
>>
>> Hmmmm, I'm not sure the above info is correct...
>>
>> I was able to find this via:
>>
>> git://gitorious.org/pulseaudio/mainline.git
>>
>> But not from your personal clone at the above URL...
>>
>> Strange :s
>>
>> Anyway, I'll try and merge in tonight. I don't know much about the BT
>> side of things but I doubt there will be anything too controversial in
>> there (other than 666 lines changed - very demonic :D) :)
>
>
> OK, I've had a quick review of this and while I'm no expert on this
> stuff it certainly *looks* vaguely sensible. I'll defer to your more
> indepth knowledge of bluetooth and push this to git master.
>
> My only comment is that there appear to be some fairly generic dbus
> utility functions in there that may be better suited to dbus-util.{h,c}
> so they can be reused - perhaps I've misinterpreted this tho', so feel
> free to ignore this comment if that's the case :D

Hmm, I didn't notice there is a dbus-util in pa and yes those can
probably be reused so they should be moved there.

> I've not tested at runtime (only compile tested for now), but what would
> I need to do to see this in action?
>
> I have dbus 1.4 here, are there any other requirements or will this
> "just work"?
>
> Also should we make dbus 1.4 a minimum requirement in configure.ac, or
> does this fall back gracefully (I see a few ifdefs in there but not 100%
> sure if this is backwards compatible).

It should just works, for now it has to be enabled in
/etc/bluetooth/audio.conf to really start using D-Bus to pass the
socket fd, but in case this is not enabled (or the libdbus has no
support for fd type) then it just uses the old mechanism. There is a
cover letter explaining in details how to enable it, well if it ever
went to the ml.

I actually did this to avoid build dependency on dbus 1.4 since many
distro do not have it yet and iirc Lennart said it has more changes
coming for 1.4.1, this should buy us some time to fix any possible
bug/regression.

-- 
Luiz Augusto von Dentz
Computer Engineer