[pulseaudio-discuss] Broken Volume Control

[Arun Raghavan]

On Mon, 2010-10-18 at 16:43 -0500, pl bossart wrote:
Looks like the volume control logic has taken a big hit, when I move
> the volume up and down with the slider on the Output Devices tab in
> pavucontrol, I have _huge_ pops and clicks, the volume goes to zero in
> the playback tab.

I don't get the pops and clicks here but I do see the volume going to
zero.

> Git bisect flags the following patch and I manually confirmed that
> this patch introduces the noises. Arun, can you look into this? I
> noticed that there are some inconsistencies on the use of
> !PA_VOLUME_IS_VALID, sometimes the ! is missing.

I'm attaching a patch for this. It solved the volume-to-zero problem for
me. Could you see if the pops and clicks go away too?

Thanks,
Arun