[pulseaudio-discuss] [PATCH] volume: Fix incorrect usage of PA_VOLUME_IS_VALID

Colin Guthrie gmane at colin.guthr.ie
Tue Oct 19 01:56:02 PDT 2010

'Twas brillig, and Arun Raghavan at 19/10/10 08:33 did gyre and gimble:
> The commit that introduced this macro was incorrect in some places. This
> patch fixes these. Thanks to Pierre-Louis Bossart for pointing this out.

I thought I'd looked over all the cases where this was used to spot
these as I was mindful that this could have been a problem easily
introduced with this kind of change, but clearly I didn't do a good job.
So much for that :s

I've pushed this patch now as it's very obvious from looking at the
changes that it's needed.

Would be good if it did solve all of Pierre's issues too.



Colin Guthrie

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]

More information about the pulseaudio-discuss mailing list