[pulseaudio-discuss] [PATCH] Do not use tsched watermark if tsched is disabled

[Colin Guthrie]

'Twas brillig, and David Henningsson at 14/09/10 07:28 did gyre and gimble:
>> Perhaps the problem is that /bin/sh is not actually bash on your system?
> 
> It is "dash" on Ubuntu systems.

Yeah I think I remember someone saying that before which is what made me
think of this as the problem :)

>> Perhaps just changing the first line to:
>>
>> #!/bin/bash would cause it to tidy things up properly?
> 
> Yes, that worked, thanks.

Cool.

>> OK, sounds reasonable. Do you think the patch I posted is OK with the
>> 1330 time?
> 
> I think it is good enough for now. If it turns out to be too little, we
> can adjust it later.

OK, I've pushed patch to both master and stable queue now.

>> I guess it's not super important as if it solves your original problem
>> that kicked off this whole thread, then that's the main thing!!
> 
> That PA can handle a stress test is important, but it's a different issue.

I found another issue that perhaps could have caused snd_pcm_start() to
not be called in alsa-sink, but it seems unrelated to this issue. I
think it's still a valid fix tho', so have pushed that too.

I think I'm quite happy with stable-queue just now. I'll try and do some
more stress testing in due course, but failing any further issues, I
think we can just call this 0.9.22 and be done with it (until the next
set of fixes come in ;))

Col



-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mandriva Linux Contributor [http://www.mandriva.com/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]