[pulseaudio-discuss] [PATCH] call-state-tracker: New component.
ext-tanu.kaskinen at nokia.com
Tue Apr 5 05:09:37 PDT 2011
On Tue, 2011-04-05 at 14:43 +0300, Tanu Kaskinen wrote:
> From: Tanu Kaskinen <ext-tanu.kaskinen at nokia.com>
> src/Makefile.am | 1 +
> src/pulsecore/call-state-tracker.c | 127 ++++++++++++++++++++++++++++++++++++
> src/pulsecore/call-state-tracker.h | 54 +++++++++++++++
> 3 files changed, 182 insertions(+), 0 deletions(-)
> create mode 100644 src/pulsecore/call-state-tracker.c
> create mode 100644 src/pulsecore/call-state-tracker.h
This is sort of ugly - I think pulsecore isn't really the right place
for this kind of things. But take it if you don't think it's too ugly.
We depend on this patch on Maemo (and Meego too, I believe).
I'd be interested in implementing at some point (no promises or
timelines) a small framework for making inter-module communication
easier, or at least cleaner (this kind of hacks in pulsecore are
actually very easy to work with, but clean they are not). The main
motivation for this would be ripping out the dbus stuff from
module-stream-restore. The dbus API implementation in
module-stream-restore.c takes about a half of the whole file, which
makes reading the stream-restore code more difficult than it should be.
I'd like to keep the dbus interface implementation in
module-dbus-protocol only. For this to be possible, there would need to
be some way for the modules to talk to each other. It could be solved in
a similar way as this call-state-tracker is done, but I'd prefer a
generic framework that modules could use to publish "extra APIs" that
other modules can then use.
More information about the pulseaudio-discuss