[pulseaudio-discuss] [PATCH] pa_poll(): Simplify detectin of invalid fds in select() emulation mode

Maarten Bosmans mkbosmans at gmail.com
Thu Apr 14 06:53:57 PDT 2011

2011/4/14 Daniel Mack <zonque at gmail.com>:
> On Thu, Apr 14, 2011 at 12:46 AM, Maarten Bosmans <mkbosmans at gmail.com> wrote:
>> return (fd >= 0) && (fcntl(fd, F_GETFL) != -1);
>> For Windows, both fcntl and F_GETFL are not available.
> Sigh. Ok, thanks for the feedback. Attached is a new patch which keeps
> things as they are for Windows but fixes the problem for OS X.

That should do it, yes.

+#else /* !OS_IS_WINDOWS */
Minor: this is not exactly the symbol used in the #ifdef.

Anyway, isn't the #else only supposed to be used for OSX? In that case
the comment should probably say so.

> Daniel


More information about the pulseaudio-discuss mailing list