[pulseaudio-discuss] Crash in RAOP sink

[David Henningsson]

I'm trying to fix a crash a few people have encountered in the upcoming 
version of Ubuntu, which uses 0.9.22 plus a few stable-queue patches.

It crashes with an assertion failure at 
modules/raop/module-raop-sink.c:246. As I don't know much about these 
RAOP things, the below was the best I could come up with. Any thoughts?

Here's a link to the stack trace: 
https://i68752006.restricted.launchpadlibrarian.net/68752006/ThreadStacktrace.txt?token=492a8975a0bfe5d32e7feca41d576110

diff --git a/src/modules/raop/module-raop-sink.c 
b/src/modules/raop/module-raop-sink.c
index 466488e..edeb542 100644
--- a/src/modules/raop/module-raop-sink.c
+++ b/src/modules/raop/module-raop-sink.c
@@ -243,9 +243,8 @@ static int sink_process_msg(pa_msgobject *o, int 
code, void *data, int64_t offse
          }

          case SINK_MESSAGE_RIP_SOCKET: {
-            pa_assert(u->fd >= 0);
-
-            pa_close(u->fd);
+            if (u->fd >= 0)
+                pa_close(u->fd);
              u->fd = -1;

              if (u->sink->thread_info.state == PA_SINK_SUSPENDED) {




-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic