[pulseaudio-discuss] RFC: Filter module loader

[Colin Guthrie]

Forgot to say but I have this patch lined up too to make the
filter.want=equalizer-sink stuff work.

Better argument standardisation across the board welcome. Happy for any
suggestions on naming conventions or leaving it as it is.

Also, I had to apply this patch to equalizer-sink to prevent it from
crashing the server on unload:

diff --git a/src/modules/module-equalizer-sink.c
b/src/modules/module-equalizer-sink.c
index 0bbb23a..611f7dd 100644
--- a/src/modules/module-equalizer-sink.c
+++ b/src/modules/module-equalizer-sink.c
@@ -1286,7 +1286,7 @@ void pa__done(pa_module*m) {

     save_state(u);

-    dbus_done(u);
+    //dbus_done(u);

     for(c = 0; c < u->channels; ++c)
         pa_xfree(u->base_profiles[c]);


I mentioned this in another thread... hopefully someone more familiar
with dbus can take a look at the underlying issue here :)

Col



-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-equalizer-Use-sink_master-as-the-module-argument-rat.patch
Type: text/x-patch
Size: 1776 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20110415/efb4b9e0/attachment.bin>