[pulseaudio-discuss] RFC: Filter module loader

[Colin Guthrie]

'Twas brillig, and Tanu Kaskinen at 21/04/11 05:55 did gyre and gimble:
> On Fri, 2011-04-15 at 20:55 +0200, Colin Guthrie wrote:
>> Also, I had to apply this patch to equalizer-sink to prevent it from
>> crashing the server on unload:
>>
>> diff --git a/src/modules/module-equalizer-sink.c
>> b/src/modules/module-equalizer-sink.c
>> index 0bbb23a..611f7dd 100644
>> --- a/src/modules/module-equalizer-sink.c
>> +++ b/src/modules/module-equalizer-sink.c
>> @@ -1286,7 +1286,7 @@ void pa__done(pa_module*m) {
>>
>>      save_state(u);
>>
>> -    dbus_done(u);
>> +    //dbus_done(u);
>>
>>      for(c = 0; c < u->channels; ++c)
>>          pa_xfree(u->base_profiles[c]);
>>
>>
>> I mentioned this in another thread... hopefully someone more familiar
>> with dbus can take a look at the underlying issue here :)
> 
> I took a look. The issue was that the dbus protocol used a string from
> the equalizer module as a key to an internal hashmap, instead a copy of
> the string. This caused trouble when the equalizer module freed the
> string.
> 
> A patch is coming.

Kick ass! Thanks :)

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]