[pulseaudio-discuss] [PATCH] core: Drop empty gaps in the memblockq when playing data from it.

[Colin Guthrie]

'Twas brillig, and Colin Guthrie at 20/04/11 15:04 did gyre and gimble:
> 'Twas brillig, and Antti-Ville Jansson at 20/04/11 14:00 did gyre and
> gimble:
>> The assert that this patch fixes can be reproduced with e.g. the
>> following script:
>>
>>
>> SAMPLE_PATH="/usr/share/sounds/alsa/"
>> SAMPLE="Front_Left"
>>
>> pactl remove-sample $SAMPLE 2> /dev/null
>> pactl upload-sample $SAMPLE_PATH$SAMPLE.wav
>>
>> mod1=`pactl load-module module-null-sink sink_name=null1`
>> mod2=`pactl load-module module-null-sink sink_name=null2`
>>
>> pactl play-sample $SAMPLE null1
>>
>> input=`pactl list | grep "Sink Input #" | tail -n 1 | cut -d# -f2`
>>
>> echo "Sample $SAMPLE playing as Sink Input #$input"
>>
>> pactl move-sink-input $input null2
>> pactl move-sink-input $input null1
>>
>> pactl unload-module $mod1
>> pactl unload-module $mod2
> 
> Thanks for the awesome test case. I'll take a look at this shortly :)

I've had a play with this and can reproduce the problem with current git
master and confirmed that your patch solved the issue.

I've modified the commit message to include the above test case for
completeness.

Many thanks.

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]