[pulseaudio-discuss] Cleanup of configure.ac
gmane at colin.guthr.ie
Sat Apr 30 07:46:21 PDT 2011
'Twas brillig, and Maarten Bosmans at 30/04/11 14:25 did gyre and gimble:
> This patch series cleans up the --enable-<feature> handling part of configure.ac.
> It changes the testing of features so that they are all done in the same way.
> The linecount of configure.ac is reduced from around 1800 with 450 lines. This is partly because os using macro's,
> partly due to simplification of if/else logic and also a bit due to rewriting stuff to one line. I think the
> readability of configure.ac is greatly improved.
> The only feature that is lost is the error message when --enable-foo=arg is used with arg something other than yes or
> no. Instead now silently the default is used. This is no big loss IMHO, because usually just --enable-foo or
> --disable-foo is given to configure.
I didn't even now you could call it with --enable-foo=no so I totally
agree that it's much more common to use --enable-foo or --disable-foo.
Not a great loss IMO.
> [PATCH 1/7] build-system: Simplify AC_ARG_ENABLE usage
I had to modify slightly due to XCB patch in my tree... nothing major
tho' (just the pkg-config stuff relating to xcb deps).
> [PATCH 2/7] build-system: Use AS_IF macro for configure output
> [PATCH 3/7] build-system: Move AC_DEFINE to separate line with AS_IF
> [PATCH 4/7] build-system: Move dependency error messages to outer scope
> [PATCH 5/7] build-system: Replace some more conditionals with AS_IF
As per patch 1 above.
> [PATCH 6/7] build-system: Rearrange database selection
> [PATCH 7/7] build-system: Small fixes
Pushed now :)
Tribalogic Limited [http://www.tribalogic.net/]
Mageia Contributor [http://www.mageia.org/]
PulseAudio Hacker [http://www.pulseaudio.org/]
Trac Hacker [http://trac.edgewall.org/]
More information about the pulseaudio-discuss