[pulseaudio-discuss] [PATCH] protocol-native: Allow clients to know at what index underrun occurred

[David Henningsson]

On 2011-08-02 18:29, Tanu Kaskinen wrote:
> On Tue, 2011-08-02 at 14:59 +0200, David Henningsson wrote:
>> On 2011-08-02 14:34, David Henningsson wrote:
>>> This patch introduces some extra protocol information, so protocol
>>> version is bumped. This functionality is primarily needed to solve
>>> a long standing issue in alsa-plugins, which should ignore underruns
>>> if and only if it is obsolete, i e, if more data has been written to
>>> the pipe in the meantime (which will automatically end the underrun).
>>>
>>> BugLink: http://bugs.launchpad.net/bugs/805940
>>> Signed-off-by: David Henningsson<david.henningsson at canonical.com>
>>
>> For reference, here's a preliminary (it has two flaws, but works for
>> testing) alsa-plugins patch that makes use of the new functionality.
>
> pcm->written is always zero - is that one of the flaws, and how can it
> work for testing?
>

Thanks for the proofreading, attaching fixed patch.
(It was accidentally lost when I removed all the debug stuff I had in 
there during development.)

The two flaws are
1) there is no way to configure handle_underrun=2
2) would make sense to make the patch fall back to old behaviour, if the 
new PA functionality is not available (perhaps both compile-time and 
run-time).

-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic