[pulseaudio-discuss] [PATCH] update process_usec before enter sleep

[Colin Guthrie]

'Twas brillig, and Pierre-Louis Bossart at 05/08/11 17:31 did gyre and
gimble:
>> during mmap_write(), there's chance to increase/decrease watermark. So
>> before
>> sleep, the actural sleep time should based on latest watermark.
> [snip] 
>> @@ -787,6 +787,7 @@ static int unix_write(struct userdata *u, pa_usec_t
>> *sleep_usec, pa_bool_t polle
> 
> Change makes sense, but this should be done both for unix_write and
> mmap_write for consistency. And while I am at it for alsa-source as well, we
> should keep the same algorithm across all cases.

Agreed. Thanks for reviewing Pierre :)

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]