[pulseaudio-discuss] [PATCH] make speex optional, make Adrian AEC optional

Arun Raghavan arun.raghavan at collabora.co.uk
Thu Dec 8 02:15:12 PST 2011


On Wed, 2011-12-07 at 15:20 +0100, Peter Meerwald wrote:
> Hello,
> attached patch makes 
> - the speex library optional (i.e. the speex resampler and the speex 
> acoustic echo canceller, AEC) 
> - the Adrian AEC implementation in the module-echo-cancel optional
> reducing dependencies and unneeded code is desirable in embedded scenarios
> note that the patch changes the default resampler in pa_resampler_new() in 
> case speex is not available, so
> speex -> libsamplerate -> ffmpeg
> please comments

Looks good in principle. Some minor niggles. :)

1. This should be split into separate patches for adrian and speex
(trivial, I can just do this while merging the patch)

2. I'd rather pick ffmpeg as the default if speex isn't selected. The
libsamplerate resampling, while theoretically higher quality, is quite

3. We should check to make sure that at least one canceller is selected
at configure time

Possibly we should just drop the adian canceller altogether. I don't
think it has any practical purpose given that it's nowhere near the
other two in quality.


More information about the pulseaudio-discuss mailing list