[pulseaudio-discuss] [PATCH] make speex optional, make Adrian AEC optional

Dalleau, Frederic frederic.dalleau at intel.com
Thu Dec 8 02:55:32 PST 2011


Hi Peter,

Your patch contains the following :
     PA_ECHO_CANCELLER_SPEEX = 0,
+#ifdef HAVE_SPEEX
+    PA_ECHO_CANCELLER_SPEEX,
+#endif
+#ifdef HAVE_ADRIAN_EC
     PA_ECHO_CANCELLER_ADRIAN,

This will lead to a bug if Speex is disabled and Adrian
or WRT is enabled, since ec_table will contain Adrian or WRT at index 0.

And also, you'll say I'm picky but when ./configure finishes,
it displays a summary with a lot of yes and no. The yes or
no corresponding to Adrian's is not vertically aligned with the
others.

Regards,
Frédéric


More information about the pulseaudio-discuss mailing list