[pulseaudio-discuss] --disable-nls?

[Arun Raghavan]

On Thu, 2011-12-15 at 13:24 +0530, Arun Raghavan wrote:
> On Wed, 2011-12-14 at 18:21 +0100, Peter Meerwald wrote:
> > Hello,
> > 
> > I have issues with commit 30d6303abff107ea0661af8cf2ae4e0abad8d73e when 
> > using configure --disable-nls
> > 
> > +if test "x$enable_nls" != "xno"; then
> >  IT_PROG_INTLTOOL([0.35.0])
> >  GETTEXT_PACKAGE=pulseaudio
> >  AC_SUBST([GETTEXT_PACKAGE])
> > @@ -103,6 +104,7 @@ AM_GLIB_GNU_GETTEXT
> >  
> >  pulselocaledir='${prefix}/${DATADIRNAME}/locale'
> >  AX_DEFINE_DIR(PULSE_LOCALEDIR, pulselocaledir, [Gettext locale dir])
> > +fi
> > 
> > the issue is that build fails in po/Makefile as USE_NLS is not set by
> > configure but po/Makefile.in.in does something like 
> > all: all- at USE_NLS@
> > which ends up as
> > all: all-
> > and all- is unknown -- so USE_NLS should be either yes or no but not 
> > undefined
> > 
> > my workaround is to rework above construct to
> > if test "x$enable_nls" != "xno"; then
> > IT_PROG_INTLTOOL([0.35.0])
> > ... as before
> > else
> > USE_NLS=no
> > fi
> > 
> > 
> > --disable-nls worked for me before; I think commit 
> > 30d6303abff107ea0661af8cf2ae4e0abad8d73e should be reverted or fixed
> 
> Good catch. The issue seems to be that the IT_PROG_INTLTOOL macro checks
> for intltool regardless of the value of $enable_nls. Let's see if we can
> get this fixed in the intltool m4 macro. If not, something like what you
> suggest might be necessary.

Looks like upstream will take some time to fix it, so I'm pushing the
workaround you suggested in the mean time (ref:
https://bugs.launchpad.net/intltool/+bug/904647 )

Thanks,
Arun