[pulseaudio-discuss] [PATCH] consistently use parameter name p for a pa_proplist in prototype

[Maarten Bosmans]

2011/12/12 Peter Meerwald <pmeerw at pmeerw.net>:
> From: Peter Meerwald <p.meerwald at bct-electronic.com>
>
> ---
>  src/pulse/proplist.h |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/pulse/proplist.h b/src/pulse/proplist.h
> index 52bc5ba..b95cfc9 100644
> --- a/src/pulse/proplist.h
> +++ b/src/pulse/proplist.h
> @@ -391,13 +391,13 @@ void pa_proplist_clear(pa_proplist *p);
>
>  /** Allocate a new property list and copy over every single entry from
>  * the specific list. \since 0.9.11 */
> -pa_proplist* pa_proplist_copy(pa_proplist *t);
> +pa_proplist* pa_proplist_copy(pa_proplist *p);

It would be nice to keep the variable name in the function
implementation the same as it is in the definition. (I know it wasn't
already before your change, but even so)

>  /** Return the number of entries in the property list. \since 0.9.15 */
> -unsigned pa_proplist_size(pa_proplist *t);
> +unsigned pa_proplist_size(pa_proplist *p);
>
>  /** Returns 0 when the proplist is empty, positive otherwise \since 0.9.15 */
> -int pa_proplist_isempty(pa_proplist *t);
> +int pa_proplist_isempty(pa_proplist *p);
>
>  /** Return non-zero when a and b have the same keys and values.
>  * \since 0.9.16 */
> --
> 1.7.4.1
>
> _______________________________________________
> pulseaudio-discuss mailing list
> pulseaudio-discuss at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss