[pulseaudio-discuss] [PATCH] stream-restore: Add properties to suppress save/restore of volume

Colin Guthrie gmane at colin.guthr.ie
Tue Feb 1 08:07:06 PST 2011


'Twas brillig, and Arun Raghavan at 01/02/11 15:02 did gyre and gimble:
> This allows clients to set stream.save_volume and stream.restore_volume
> to control whether a stream's volume should be saved/restored
> respectively. We make save_volume a property instead of a flag since the
> application might not know at stream creation time whether it wants the
> volume to be saved or not. To keep things conistent, restore_volume is a
> property as well (even though it is only meaningful to set at stream
> creation time).

This seems pretty clean and harmless. So I'm not against it. It may have
to be reworked when I/someone eventually gets round to doing the
priority lists things, but that's no big deal and I certainly wouldn't
expect anyone to wait for it!

I don't think we put spaces before function calls tho', but I can fix
that up on merge if no one else has any major objections to this patch.

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]




More information about the pulseaudio-discuss mailing list