[pulseaudio-discuss] [PATCH] src/Makefile.am: add missing space to fix build using uClibc

[Paul Menzel]

Am Samstag, den 19.02.2011, 14:19 +0100 schrieb Maarten Bosmans:
> 2011/2/19 Paul Menzel <paulepanter at users.sourceforge.net>:
> > From: Henning Heinold <heinold at inf.fu-berlin.de>
> > Date: Fri Jul 10 12:33:30 2009 +0200
> >
> > Using uClibc
> >
> >        AM_LIBADD = $(PTHREAD_LIBS) $(INTLLIBS)
> >
> > is not empty because `$(INTLLIBS)` is set to `-lintl`. This uncovered a missing space in commit ef0cc745 which resulted in the following build error.
> >
> >        […]
> >                CC     libbluetooth_ipc_la-ipc.lo
> >        modules/bluetooth/ipc.c: In function 'bt_audio_service_open':
> >        modules/bluetooth/ipc.c:65:26: warning: dereferencing type-punned pointer might break strict-aliasing rules [-Wstrict-aliasing]
> >        modules/bluetooth/ipc.c: In function 'bt_audio_service_get_data_fd':
> >        modules/bluetooth/ipc.c:110:13: warning: cast increases required alignment of target type [-Wcast-align]
> >        modules/bluetooth/ipc.c:110:4: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
> >        make[3]: *** No rule to make target `-lintl', needed by `libbluetooth-ipc.la'.  Stop.
> >        make[3]: Leaving directory `/oe/build-minimal-uclibc/minimal-uclibc-dev/work/armv7a-oe-linux-uclibceabi/pulseaudio-0.9.22-r11.0+gitr0+051d82133f0ae6a57bf66fd200bc8e3591a7d5ca/git/src'
> >        make[2]: *** [all] Error 2
> >        make[2]: Leaving directory `/oe/build-minimal-uclibc/minimal-uclibc-dev/work/armv7a-oe-linux-uclibceabi/pulseaudio-0.9.22-r11.0+gitr0+051d82133f0ae6a57bf66fd200bc8e3591a7d5ca/git/src'
> >        make[1]: *** [all-recursive] Error 1
> >        make[1]: Leaving directory `/oe/build-minimal-uclibc/minimal-uclibc-dev/work/armv7a-oe-linux-uclibceabi/pulseaudio-0.9.22-r11.0+gitr0+051d82133f0ae6a57bf66fd200bc8e3591a7d5ca/git'
> >        make: *** [all] Error 2
> >
> > This patch is taken from OpenEmbedded where it has been present since 2009 for PulseAudio 0.9.15 and greater [1].
> 
> Hmm, yes indeed. What ever happened to upstreaming patches?

Well what I saw in OpenEmbedded is that there only some dozens of people
seem to maintain a whole frame work for building distributions and so
they seem to not have much time to get patches upstream. Maybe Henning –
keep him in CC please – can comment what could be improved.

Additionally there is no maintainer per recipe so it takes even more
time to figure out how patches have to be formatted and submitted. And
at least for PulseAudio the Web site says or suggests – as far as I know
– to open a Trac ticket for which you have to register and operate
through a Web interface. And if there is a list you often have to
subscribe to send messages.

Well it is good to know that patches can be sent to the list too.

> Is there any more interesting stuff OpenEmbedded (or any other
> distro/downstream for that matter) that isn't in git master yet?

Concerning OpenEmbedded you can see the patches in the repository [1]. I
am trying to send them upstream during the next days.

[…]


Thanks,

Paul


[1] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/pulseaudio/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20110219/0af3566d/attachment.pgp>