[pulseaudio-discuss] [PATCH] sbc_math.h: add explicit check for ARMv6 instructions

[Arun Raghavan]

On Tue, 2011-02-22 at 09:48 +0000, Colin Guthrie wrote:
> 'Twas brillig, and Arun Raghavan at 21/02/11 20:31 did gyre and gimble:
> > On Sun, 2011-02-20 at 19:20 +0100, Paul Menzel wrote:
> >> Date: Sun, 20 Feb 2011 15:57:55 +0100
> >>
> >> Building PulseAudio 051d8213 [1] using OpenEmbedded with distribution `minimal-uclibc` for `MACHINE="om-gta01"` having an ARMv4T architecture (armv4t-oe-linux-uclibceabi) compilation fails with the following error.
> > [...]
> >> 	{standard input}:4099: Error: selected processor does not support Thumb mode `mla r3,r2,r6,r3'
> >> 	{standard input}:4114: Error: selected processor does not support Thumb mode `mla r3,r2,ip,r3'
> >> 	{standard input}:4125: Error: selected processor does not support Thumb mode `mla r3,r6,r2,r3'
> >> 	make[3]: *** [libbluetooth_sbc_la-sbc.lo] Error 1
> >>
> >> Apply the same fix as in [2], which is similar to the patch applied in OpenEmbedded since commit 976ab4b5 [3].
> >>
> >> [1] http://git.0pointer.de/?p=pulseaudio.git;a=commit;h=051d82133f0ae6a57bf66fd200bc8e3591a7d5ca
> >> [2] http://git.0pointer.de/?p=pulseaudio.git;a=commit;h=12b900858ae82d435c100d6eb94cb7bb22fe5e29
> >> [3] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=976ab4b4587d548c0483a274058c5359cb72bf1b
> >>
> >> Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
> >> CC: Marcel Holtmann <marcel at holtmann.org>
> >> ---
> >> I do not know if these files are just copied from linux-bluetooth upstream, so I am adding Marcel to CC anyway because he is mentioned in the copyright section.

Looking at src/Makefile.am, it looks like at some point of time, we
pulled bluez files directly from git (the update-sbc rule). Does anyone
know what the plan was with regards to keeping these files up-to-date?
There seem to be a bunch of armv6 updates upstream as well.

[...]
> Paul, can you confirm if this avoids the problem for you? If so, then
> Arun, can you make a proper patch? You can? Awesome, thanks :)

:D Once we've resolved what the situation is with bluez files, I'm happy
to help with this.

Cheers,
Arun