[pulseaudio-discuss] [PATCH] Add a target to the PA log feature and improve PA log core

Maarten Bosmans mkbosmans at gmail.com
Wed Feb 23 08:29:39 PST 2011


2011/2/23 Becker, VincentX <vincentx.becker at intel.com>:
> Thanks for your review Maarten. So you suggest to split this into several patches (2). One for the outer implementation and the other for the inner one. I will try to attend to the irc meeting tomorrow so I can catch your remarks in real time.

I'm not sure what you mean by outer and inner implementation. What I
meant was one patch thats adds the option to log to a file (this patch
touches all four files) and one patch that does the metadata,
append_data thing (should only change src/pulsecore/log.c)

Having two clean patches (see my other comments) tomorrow would help
to keep thing moving in the meeting.

Sorry for getting this rolling on such a short notice.

Maarten

>
> Cheers,
> V.



More information about the pulseaudio-discuss mailing list