[pulseaudio-discuss] [PATCH] [module-loopback] Add new arguments sink_dont_move and source_dont_move to toggle module automatic unloading when the sink or source were not available

Cai Yuanqing yuanqing.cai at tieto.com
Mon Jan 3 18:22:24 PST 2011


On 01/04/2011 02:10 AM, pl bossart wrote:
> On Thu, Dec 23, 2010 at 5:40 AM, Cai Yuanqing<yuanqing.cai at tieto.com>  wrote:
>>     This patch add two new boolean arguments sink_dont_move and
>> source_dont_move into module-loopback,so we can make the module unloading
>> when the sink or source was unavailable.
>> To enable this feature we can do something like:
>>>>> load-module module-loopback source=bluez_source.00_22_A5_AA_BF_85
>>>>> sink=alsa_output.pci-0000_00_1b.0.analog-stereo source_dont_move=TRUE
>> And you can just feel free to ignore these arguments.
> I don't have any arguments against the source_dont_move, but I am
> concerned about the sink_dont_move part. You may want to listen to
> your music on speakers, headsets, HDMI, etc. Why would you restrict
> the playback to the sink selected when you loaded the module? I can
> see this interfering with the accessory management/audio policy, at
> least in Meego. Falling back to the default sink should not add any
> noises?
> -Pierre
Thanks for your feedback.

In fact I also don't want to add sink_dont_move at very beginning,adding 
this "sink_dont_move" arguments because there is no reason to add 
"source_dont_move" only, it sounds weird and I can't answer question 
that "Why the sink have no XX_dont_move here,I just want to do this for 
my reasons?".So I add this one .
IMHO,we can ignore this argument in mostly situations and move the sink 
to default sink or other sinks when current sink are not available.

Falling back to the default sink may make some noises sound but not 
always,It's very occasional and may related to compatibility issue.

-- 
B.R

Cai Yuanqing




More information about the pulseaudio-discuss mailing list