[pulseaudio-discuss] [PATCH 08/10] Add AM_LDFLAGS more consistently to all commands

[Colin Guthrie]

'Twas brillig, and Maarten Bosmans at 06/01/11 01:39 did gyre and gimble:
> @@ -100,12 +100,12 @@ BINLDFLAGS = -static
>  endif
>  
>  if OS_IS_WIN32
> -AM_LDFLAGS+=-Wl,--export-all-symbols
> +AM_LDFLAGS+=-Wl,--export-all-symbols,--enable-auto-import -no-undefined
>  WINSOCK_LIBS=-lwsock32 -lws2_32 -lwininet
>  endif

I've got no objection to the other bits in this patch (although I'd have
thought the auto tools stuff would use AM_LDFLAGS in any LDFLAGS section
automagically...) but I'm not sure we should be mandating -no-undefined
here... This is something we add in at the distro level when appropriate
normally.

But that said, I'm not really an expert on this stuff so perhaps there
is good reason to include this here (I appreciate this change will
require your previous patch)? What do people think generally?

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]