[pulseaudio-discuss] [PATCH 5/5] alsa-sink: Don't assume we were able to enable hw-volume or sync-volume (v1.1)
gmane at colin.guthr.ie
Sat Jan 15 05:55:06 PST 2011
'Twas brillig, and oku at iki.fi at 13/01/11 14:44 did gyre and gimble:
> From: Jyri Sarha <jyri.sarha at nokia.com>
> This patch also disables mixer callback code if we do not have neither
> HW-volume or HW-mute.
Forgive me if I'm just having a slow day, but the check you are now using:
if (u->sink->flags & (PA_SINK_HW_VOLUME_CTRL|PA_SINK_HW_MUTE_CTRL))
would seem to be checking that it has *both* VOLUME and MUTE_CTRL,
rather than *either* of them.
I've merged the other 4 patches but can you take a look at this issue
(or just correct my general dumbness)?
Tribalogic Limited [http://www.tribalogic.net/]
Mageia Contributor [http://www.mageia.org/]
PulseAudio Hacker [http://www.pulseaudio.org/]
Trac Hacker [http://trac.edgewall.org/]
More information about the pulseaudio-discuss