[pulseaudio-discuss] [PATCH 0/2] Fix mingw32 compile problems

[Maarten Bosmans]

2011/6/20 Fritz Elfert <fritz at fritz-elfert.de>:
> What I didn't like about git-format-patch that it created several
> separate mails. I think multiple commits for a single problem should go
> into *one* combined diff....

The usual git workflow is to mail each commit separately with git
send-email. Often a single commit is large enough that it doesn't make
sense to combine several of them in one email. In your case though,
both commits were only a couple of lines, so they could easily have
been done in one mail (and one patch, as they are in master now)

> Meanwhile, I have some more local changes here:
>
>  - Added a new --log-target "windbg" which replaces "syslog" on win32
> builds. Logging is done via OutputDebugStringA(). Log output can
> watched for example with SysInternal's debugview.

Great, that brings us closer to being able to run pulse as a service
instead of from the command line.
Please squash the three windbg commits into one with git rebase before
posting. (ping me on IRC tomorrow if you need help with this)

>  - Fixed a very annoying (at least for me, while trying to build on Mac
> OSX) misbehavior of configure:
>
> The switch --disable-nls was completely ignored. This were actually 2
> bugs in M4 macros used by pulseaudio. a) The provided intltool.m4 did
> complain about missing intltool even when disabling NLS. b) The
> invocation of AM_GLIB_GNU_GETTEXT always enables NLS if it finds any
> gettext stuff on the build system even if disabled by --disable-nls.

I don't think pulseaudio provides intltool.m4. That gets installed by
aclocal in bootstrap.sh from the build system.

> Ok to post those here, or shall I create a pull request on github?

Arun and Colin are the only commiters (besides Lennart), so they get
to state their preference, but I'd say post on the list, because then
all the review and discussion can also happen here. A pull request
from a public git branch is mainly useful when you have a lot (like 10
or more) related commits in a series.

Maarten

> Cheers,
>  -Fritz