[pulseaudio-discuss] [PATCH] SSE/MMX: Fix problem with highpitched noise on i386

[Colin Guthrie]

'Twas brillig, and Colin Guthrie at 21/06/11 09:49 did gyre and gimble:
> 'Twas brillig, and David Henningsson at 21/06/11 09:38 did gyre and gimble:
>> The "rm" basm constraint doesn't work with my version of gcc (4.5.2),
>> not even in a simple example. Since we usually only have 5 registers
>> available on i386, force it to be memory on that architecture.
>>
>> I've reported an Ubuntu bug on the "rm" constraint issue [1], and it
>> seems to apply to a lot of gcc versions. In the meantime I recommend
>> this patch to be applied to both master and stable-queue. I've got some
>> positive feedback from testing in the Ubuntu community as well.
> 
> ACK on committing to both. Will do it shortly if Arun doesn't beat me to
> it :D
> 
>> @Colin, I haven't forgot that there might still be issues if you
>> completely silence one channel, it just hasn't been time/priority to
>> deal with that yet, feel free to beat me to it if you like :-)
> 
> Considering my assembly-fu is as weak as my kung-fu, I'll likely no be
> beating you to it :D
> 
> Many thanks :)

Pushed to master and s-q now. Thanks.

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]