[pulseaudio-discuss] [PATCH] Add windbg log target + Fix configure not honoring --without-nls

[Colin Guthrie]

Hi,

'Twas brillig, and Fritz Elfert at 23/06/11 21:31 did gyre and gimble:
> Maarten suggested to hurry as 1.0 is on it's way, so attached are two
> more patches:
> 
> 1. 0001-mingw-logtarget-windbg.patch (win32 platform)
> 
> Adds a new log target named "windbg" for windows builds which replaces
> the "syslog" target on this platform. It uses OutputDebugString() for
> logging. This is a core feature in windows which is similar to the
> kernel's message ringbuffer (i.e.: no log files, log entirely in memory,
> not persistent)
> For reading such logs, a tool named dbgview is available at
> www.sysinternals.com

Sounds worthwhile, but I'm not overly keen on all the #ifdefs needed for
this.

Would it be too much to expect that the term (in e.g. command line and
config options etc.) remain as "syslog" but on windows this means
windbg? That would keep the code a lot cleaner at the expense of
(perhaps) a little loss on clarity for win32 users. Obviously comments
can be added (unconditionally) to man pages and documentation, to
alleviate this.

As an alernative, I'd be happy enough changing "syslog" to be "system"
(although still allowing syslog as an undocumented alias) in all the
code, config and man pages.

I think this would be cleaner overall and save on several #ifdefs.

If you could fix this and supply a proper git-formatted patch (not just
a diff) I'll happily commit.

> 2. 0002-configure-honor-without-nls.patch (all platforms)
> 
> Despite what configure --help says, the current setup does ignore this
> flag, always using NLS (and linking against libintl etc.) This is
> actually not a bug in pulseaudio itself but 2 bugs in intltool and
> glib's gettext M4 macros. Since intltool looks pretty dead to me (last
> commit ages ago) and I needed a fix *fast*, I chose to implement a
> workaround for that.

Maarten had some thought on this one, so will comment shortly.

Cheers

Col



-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]