[pulseaudio-discuss] [PATCH] Get rid of some warnings

Arun Raghavan arun.raghavan at collabora.co.uk
Sun Mar 20 06:32:19 PDT 2011


On Sun, 2011-03-20 at 13:12 +0000, Colin Guthrie wrote:
> 'Twas brillig, and Maarten Bosmans at 19/03/11 15:26 did gyre and gimble:
> > Mostly warnings about unused stuff.
> > Furthermore, the first hunk is a fix for the change in 177948a6.
> > Finally, comment in AEC_dtd was translated and the code simplified slightly.
> 
> Thanks :)
> 
> > CC     module_echo_cancel_la-adrian-aec.lo
> > modules/echo-cancel/adrian-aec.h:360:15: warning: ‘AEC_getambient’ defined but not used [-Wunused-function]
> > modules/echo-cancel/adrian-aec.h:368:14: warning: ‘AEC_setgain’ defined but not used [-Wunused-function]
> > modules/echo-cancel/adrian-aec.h:374:14: warning: ‘AEC_setaes’ defined but not used [-Wunused-function]
> > modules/echo-cancel/adrian-aec.h:377:16: warning: ‘AEC_max_dotp_xf_xf’ declared ‘static’ but never defined [-Wunused-function]
> 
> Is the Adrian code ours or is it external in some capacity. Arun, if
> it's external and we will update it periodically, can you do the
> necessary to push where it needs to go? (Obviously the PA_GCC_UNUSED
> cannot be pushed anywhere).

The upstream code isn't actively developed, and if it does, I'm going to
have to do a manual merge anyway (since the original code was C++). So
all good here. :)

Cheers,
Arun




More information about the pulseaudio-discuss mailing list