[pulseaudio-discuss] [PATCH] Get rid of some warnings

[Arun Raghavan]

On Sun, 2011-03-20 at 22:56 +0100, Maarten Bosmans wrote:
> 2011/3/20 Colin Guthrie <gmane at colin.guthr.ie>:
> > 'Twas brillig, and Maarten Bosmans at 19/03/11 15:26 did gyre and gimble:
> >> Mostly warnings about unused stuff.
> >> Furthermore, the first hunk is a fix for the change in 177948a6.
> >> Finally, comment in AEC_dtd was translated and the code simplified slightly.
> >
> > Thanks :)
> >
> >> CC     module_echo_cancel_la-adrian-aec.lo
> >> modules/echo-cancel/adrian-aec.h:360:15: warning: ‘AEC_getambient’ defined but not used [-Wunused-function]
> >> modules/echo-cancel/adrian-aec.h:368:14: warning: ‘AEC_setgain’ defined but not used [-Wunused-function]
> >> modules/echo-cancel/adrian-aec.h:374:14: warning: ‘AEC_setaes’ defined but not used [-Wunused-function]
> >> modules/echo-cancel/adrian-aec.h:377:16: warning: ‘AEC_max_dotp_xf_xf’ declared ‘static’ but never defined [-Wunused-function]
> >
> > Is the Adrian code ours or is it external in some capacity. Arun, if
> > it's external and we will update it periodically, can you do the
> > necessary to push where it needs to go? (Obviously the PA_GCC_UNUSED
> > cannot be pushed anywhere).
> 
> I checked that there were already a lot of changes in git after the
> inital import, and Arun seems to confirm.
> Arun: what is the license of those files?, it doesn't really say in
> the header. May be a audit of all files/licenses should be done in
> general?

There's a note about it at the bottom of LICENSE in the top directory.
Maybe we should add something similar for the bluez bits as well.

Cheers,
Arun