[pulseaudio-discuss] [PATCH 2/2] Move compile-time checks around pa_run_from_build_tree to core-util

Colin Guthrie gmane at colin.guthr.ie
Thu Mar 24 04:24:43 PDT 2011


'Twas brillig, and Arun Raghavan at 24/03/11 11:04 did gyre and gimble:
> On Thu, 2011-03-24 at 11:46 +0100, Maarten Bosmans wrote:
> [...]
>> I think only compiling that on developer builds and inlining return
>> FALSE for normal, e.g. distro builds makes sense. However __OPTIMIZE__
>> is not a good differentiator here.
> 
> The callers all seem to be initialisation routines only, so why not just
> let it be called in distro and manual builds?

That's kinda what I was thinking too. It's only a couple extra checks at
startup, so it's probably not a massive deal overall to leave this check
in for distro builds, tho' I agree it would be nice to miss it out if
possible.... not sure there is such a way :s

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]




More information about the pulseaudio-discuss mailing list