[pulseaudio-discuss] Current problems with git master

[Colin Guthrie]

'Twas brillig, and Colin Guthrie at 28/02/11 20:26 did gyre and gimble:
> Hi,
> 
> Just cataloguing my issues so we don't forget....
> 
> 1. It seems that when running pulseaudio -k, that the daemon terminates
> pretty brutally... I'm not yet sure if the daemon dies horribly or just
> doesn't unload the modules properly. Due to this, the X11 properties on
> the root window are left over (because they were inserted by
> module-x11-publish). Due to this, the daemon will not autospawn or be
> started properly.
> 
> This indicates two separate problems:
>  a) The module shutdown process is not quite working right.
>  b) The code that detects whether the connection params (in the left
> over x11 props) are meant to be local (which indicates a crash) so that
> autospawn or manual startup will proceed successfully.

OK, I've not debugged part a) here but I've taken a look at b).

It turns out this behaviour was introduced in:

commit f1d1447e104c4f609c0e8c528b56ea6afa540b95
Author: Tanu Kaskinen <tanuk at iki.fi>
Date:   Sat Jan 9 11:55:15 2010 +0200

    daemon: Don't autospawn if a server address is explicitly configured.



This has a slight problem. I'll just past the commit message of my patch
to resolve this issue as it explains it.

Does this patch look OK to everyone (especially Tanu!)


daemon: Fix regression introduced in f1d1447e.

With Tanu's patch, the server no longer starts when a server is
configured. While this is sensible in most circumstances there is a
corner case where we still want to start.

In a typical X11 login, module-x11-publish will be loaded and will thus
set the PULSE_SERVER X11 property on the root window. This then hits the
check introduced in f1d1447e and exits. If PA had previously crashed
(thus leaving behind it's X11 properties) then this means that we will
not autospawn nor even allow ourselves to be started manually until
pax11publish -r is run to clear out the X11 properties. This is
obviously not desirable.

This patch introduces a more in-depth check of the server. If it looks
like a local unix domain socket, then we do not exit straight away and
instead probe further. This should not pose any problems with e.g.
remote SSH usage as the DBus Machine ID is used in the server string.

Thanks.

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-daemon-Fix-regression-introduced-in-f1d1447e.patch
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20110325/2f145bee/attachment.txt>