[pulseaudio-discuss] module combine not respecting requested latencies

[Maarten Bosmans]

2011/5/9 Maarten Lankhorst <m.b.lankhorst at gmail.com>:
> Hi all,
>
> I was toying around with the combine module, but it appears it adds a lot
> latency for no good reason, changing it from 200 ms to 10 ms makes some
> applications like wine happier. I wanted to see if I could fix it myself,
> but I must admit I don't understand what the various parts of that code do.

Please have another look at your patch. This is setting BLOCK_USEC to
10 seconds, not ms. Moreover, I don't think BLOCK_USEC is related in
any way to the default adjust_time, so if changing BLOCK_USEC, better
set it to some other hardcoded value, to avoid the suggestion that it
has anything to do with the adjust_time.

> The fact that is's both an input and output make it even harder..
> A naive patch to fix it is here, but it would have been nice if module
> combine would just respect the latency I ask it to set, and maybe just set a
> high latency by default otherwise.
>
> ~Maarten

Maarten

> diff --git a/src/modules/module-combine-sink.c
> b/src/modules/module-combine-sink.c
> index 09af942..138e3e8 100644
> --- a/src/modules/module-combine-sink.c
> +++ b/src/modules/module-combine-sink.c
> @@ -72,7 +72,7 @@ PA_MODULE_USAGE(
>
>  #define DEFAULT_ADJUST_TIME_USEC (10*PA_USEC_PER_SEC)
>
> -#define BLOCK_USEC (PA_USEC_PER_MSEC * 200)
> +#define BLOCK_USEC DEFAULT_ADJUST_TIME_USEC
>
>  static const char* const valid_modargs[] = {
>     "sink_name",
>
>
> _______________________________________________
> pulseaudio-discuss mailing list
> pulseaudio-discuss at mail.0pointer.de
> https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss
>