[pulseaudio-discuss] [PATCH] fix the assumption that volume is always positive

[Tanu Kaskinen]

On Thu, 2011-05-26 at 14:08 +0300, Tanu Kaskinen wrote:
> On Thu, 2011-05-26 at 09:50 +0100, Colin Guthrie wrote:
> > 'Twas brillig, and Lu Guanqun at 26/05/11 09:49 did gyre and gimble:
> > > Add a variable to track whether the actual volume is set or not.
> > > Suppose this:
> > > 	min volume: -126	max volume: 0
> > > then when user wants to set some constant volume to -10, it would fail.
> > 
> > Tanu, are you OK with this patch?
> 
> Maybe, maybe not. I posted a question to alsa-devel:
> http://mailman.alsa-project.org/pipermail/alsa-devel/2011-May/040213.html
> 
> If negative steps are allowed, I expect there to be more bugs.

I got a confirmation that negative volumes are allowed, so the patch
should be fine. Somebody should review the alsa mixer code for other
cases of the invalid assumption (I plan to do it in the indefinite
future, if nobody else does it).

-- 
Tanu