[pulseaudio-discuss] [PATCH] fix the assumption that volume is always positive
guanqun.lu at intel.com
Thu May 26 17:57:07 PDT 2011
On Thu, May 26, 2011 at 09:21:45PM +0800, Colin Guthrie wrote:
> 'Twas brillig, and Tanu Kaskinen at 26/05/11 13:48 did gyre and gimble:
> > On Thu, 2011-05-26 at 14:08 +0300, Tanu Kaskinen wrote:
> >> On Thu, 2011-05-26 at 09:50 +0100, Colin Guthrie wrote:
> >>> 'Twas brillig, and Lu Guanqun at 26/05/11 09:49 did gyre and gimble:
> >>>> Add a variable to track whether the actual volume is set or not.
> >>>> Suppose this:
> >>>> min volume: -126 max volume: 0
> >>>> then when user wants to set some constant volume to -10, it would fail.
> >>> Tanu, are you OK with this patch?
> >> Maybe, maybe not. I posted a question to alsa-devel:
> >> http://mailman.alsa-project.org/pipermail/alsa-devel/2011-May/040213.html
> >> If negative steps are allowed, I expect there to be more bugs.
> > I got a confirmation that negative volumes are allowed, so the patch
> > should be fine. Somebody should review the alsa mixer code for other
> > cases of the invalid assumption (I plan to do it in the indefinite
> > future, if nobody else does it).
> OK, sounds good. I will queue it up at my end.
> Judging by Takashi's comments on alsa-devel, in an ideal world the
> driver would be updated too to avoid the use of the negative steps
> (which is "funky" :p), but we still need this fix all the same.
I'll push a patch into the mis-behaved alsa driver to fix the negative
Thanks Tanu's info as well.
> Thanks for the patch.
> Colin Guthrie
> Day Job:
> Tribalogic Limited [http://www.tribalogic.net/]
> Open Source:
> Mageia Contributor [http://www.mageia.org/]
> PulseAudio Hacker [http://www.pulseaudio.org/]
> Trac Hacker [http://trac.edgewall.org/]
> pulseaudio-discuss mailing list
> pulseaudio-discuss at mail.0pointer.de
More information about the pulseaudio-discuss