[pulseaudio-discuss] [PATCH 1/6] Introduce "available" concept for ports, and communicate that to clients. Bump protocol version to 24.

Arun Raghavan arun.raghavan at collabora.co.uk
Tue Nov 8 01:42:43 PST 2011


On Thu, 2011-10-27 at 16:45 +0200, David Henningsson wrote:
> Note: There is still no notification when status availability changes.
> 
> Signed-off-by: David Henningsson <david.henningsson at canonical.com>
> ---
>  PROTOCOL                        |   10 ++++
>  configure.ac                    |    2 +-
>  src/modules/module-tunnel.c     |   91 +++++++++++++++++----------------------
>  src/pulse/def.h                 |   15 ++++++
>  src/pulse/introspect.c          |   16 +++++++
>  src/pulse/introspect.h          |    2 +
>  src/pulsecore/protocol-native.c |    4 ++
>  src/pulsecore/sink.h            |    1 +
>  8 files changed, 88 insertions(+), 53 deletions(-)
> 
> diff --git a/PROTOCOL b/PROTOCOL
> index 8c69190..8b2f81f 100644
> --- a/PROTOCOL
> +++ b/PROTOCOL
> @@ -278,6 +278,16 @@ New field in PA_COMMAND_UNDERFLOW:
>  
>      int64_t index
>  
> +## v24, implemented by >= 2.0
> +
> +New field in all commands that send/receive port introspection data
> +(PA_COMMAND_GET_(SOURCE|SINK)_OUTPUT_INFO,
> +PA_COMMAND_GET_(SOURCE|SINK)_OUTPUT_INFO_LIST):
> +
> +    uint32_t available
> +

We spoke about this at Prague, but do you think there might be a some
way for Ubuntu to switch this to a uint8_t on an upgrade?

It's not a huge deal, but if it's doable, it'd be good.

Rest of the patch looks good to me.

-- Arun



More information about the pulseaudio-discuss mailing list