[pulseaudio-discuss] [PATCH 2/8] build-sys: Remove check for alloca()

[Arun Raghavan]

On Wed, 2011-11-02 at 21:54 +0100, Maarten Bosmans wrote:
> As it isn't used anymore.
> Also, some minor cleanup.
> ---
>  configure.ac |   19 ++++++++-----------
>  1 files changed, 8 insertions(+), 11 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 324e32e..be31486 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -26,7 +26,9 @@ AC_INIT([pulseaudio],[m4_esyscmd(./git-version-gen .tarball-version)],[pulseaudi
>  AC_CONFIG_SRCDIR([src/daemon/main.c])
>  AC_CONFIG_MACRO_DIR([m4])
>  AC_CONFIG_HEADERS([config.h])
> -AM_INIT_AUTOMAKE([foreign 1.11 -Wall -Wno-portability silent-rules color-tests dist-xz tar-ustar])
> +
> +AM_INIT_AUTOMAKE([foreign 1.11 -Wall -Wno-portability color-tests dist-xz tar-ustar])
> +AM_SILENT_RULES([yes])
>  
>  m4_define(pa_major, `echo $VERSION | cut -d. -f1 | cut -d- -f1`)
>  m4_define(pa_minor, `echo $VERSION | cut -d. -f2 | cut -d- -f1`)
> @@ -58,14 +60,11 @@ AC_CANONICAL_HOST
>  AC_DEFINE_UNQUOTED([CANONICAL_HOST], "$host", [Canonical host string.])
>  
>  AC_CHECK_PROG([STOW], [stow], [yes], [no])
> -
>  AS_IF([test "x$STOW" = "xyes" && test -d /usr/local/stow], [
>      AC_MSG_NOTICE([*** Found /usr/local/stow: default install prefix set to /usr/local/stow/${PACKAGE_NAME}-${PACKAGE_VERSION} ***])
>      ac_default_prefix="/usr/local/stow/${PACKAGE_NAME}-${PACKAGE_VERSION}"
>  ])
>  
> -AM_SILENT_RULES([yes])
> -
>  
>  #### Checks for programs. ####
>  
> @@ -154,7 +153,7 @@ esac
>  #### Compiler flags ####
>  
>  AX_APPEND_COMPILE_FLAGS(
> -    [-Wall -W -Wextra -pipe -Wno-long-long -Wvla -Wno-overlength-strings -Wunsafe-loop-optimizations -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wformat-security -Wmissing-include-dirs -Wformat-nonliteral -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing -Wwrite-strings -Wno-unused-parameter -ffast-math -Wp,-D_FORTIFY_SOURCE=2 -fno-common -fdiagnostics-show-option],
> +    [-Wall -W -Wextra -pipe -Wvla -Wno-overlength-strings -Wunsafe-loop-optimizations -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wformat-security -Wmissing-include-dirs -Wformat-nonliteral -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wcast-align -Wstrict-aliasing -Wwrite-strings -Wno-unused-parameter -ffast-math -Wp,-D_FORTIFY_SOURCE=2 -fno-common -fdiagnostics-show-option],
>      [], [-pedantic -Werror])
>  
> 
> @@ -395,9 +394,8 @@ AC_C_CONST
>  AC_C_BIGENDIAN
>  AC_TYPE_PID_T
>  AC_TYPE_SIZE_T
> -AC_CHECK_TYPES(ssize_t, , AC_DEFINE([ssize_t], [signed long], [Define ssize_t if it is not done by the standard libs.]))
> +AC_TYPE_SSIZE_T
>  AC_TYPE_OFF_T
> -
>  AC_TYPE_UID_T
>  AC_CHECK_DECLS(environ)
>  
> @@ -482,7 +480,7 @@ AC_CHECK_FUNCS([getopt_long], [], [AC_CHECK_LIB([iberty], [getopt_long])])
>  #### Check for functions ####
>  
>  # ISO
> -AC_CHECK_FUNCS_ONCE([lrintf strtof])
> +AC_CHECK_FUNCS_ONCE([lrintf])
>  
>  # POSIX
>  AC_FUNC_FORK
> @@ -509,9 +507,8 @@ AC_CHECK_FUNCS_ONCE([strerror_r])
>  AC_CHECK_FUNCS_ONCE([lstat])
>  
>  # Non-standard
> -AC_CHECK_FUNCS_ONCE([setresuid setresgid setreuid setregid seteuid setegid ppoll strsignal sig2str strtof_l pipe2 accept4])
> -
> -AC_FUNC_ALLOCA
> +AC_CHECK_FUNCS_ONCE([setresuid setresgid setreuid setregid seteuid setegid])
> +AC_CHECK_FUNCS_ONCE([ppoll sig2str strtof_l pipe2 accept4])
>  
>  AC_CHECK_FUNCS([regexec], [HAVE_REGEX=1], [HAVE_REGEX=0])
>  AM_CONDITIONAL(HAVE_REGEX, [test "x$HAVE_REGEX" = "x1"])


Please break up patches into related changes only. I know that it's a
lot of small changes, but this sort of thing makes tracking back changes
and git bisect'ing a nightmare.

Also, this would probably be checked in alsa-lib's build already, but we
*do* use alloca via a bunch of macros in the ALSA headers.

-- Arun