[pulseaudio-discuss] [PATCH 3/3] bluetooth: Fix property reply handling for hfgw

[Colin Guthrie]

'Twas brillig, and Mikel Astiz at 23/11/11 16:08 did gyre and gimble:
> ---
>  src/modules/bluetooth/bluetooth-util.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/modules/bluetooth/bluetooth-util.c b/src/modules/bluetooth/bluetooth-util.c
> index 2e4d93c..c5befe3 100644
> --- a/src/modules/bluetooth/bluetooth-util.c
> +++ b/src/modules/bluetooth/bluetooth-util.c
> @@ -484,7 +484,7 @@ static void get_properties_reply(DBusPendingCall *pending, void *userdata) {
>                      goto finish;
>  
>              }  else if (dbus_message_has_interface(p->message, "org.bluez.HandsfreeGateway")) {
> -                if (parse_audio_property(y, &d->hfgw_state, &arg_i) < 0)
> +                if (parse_audio_property(y, &d->hfgw_state, &dict_i) < 0)
>                      goto finish;
>  
>              }


I've pushed this patch now (thanks!), but not the other two yet.

2 depends on 1 and there is some discussion about whether 1 is the
correct fix.

Also as this relates to profile switching it's possibly worth looking at
the thread regarding routing priority lists and some logic that relates
to when to switch profiles automatically which may have some bearing on
how you approach future fixes in this area (and general input on the
approach is very much appreciated anyway!)

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/