[pulseaudio-discuss] [PATCH 4/8] Avoid some compiler warnings when cross-compiling for mingw32

Colin Guthrie gmane at colin.guthr.ie
Sun Nov 27 08:32:06 PST 2011


Hi,


'Twas brillig, and Maarten Bosmans at 02/11/11 20:54 did gyre and gimble:
> Autoconf documentation says that AC_FUNC_SELECT_ARGTYPES shouldn't be used anyway.

There was an unrelated change in shm.c that does a "goto fail".

This is functionally equiv in the circumstances but I do prefer the
cleaner "goto fail" approach. However it doesn't belong in this patch.

Otherwise it compiles/runs fine for me so I can't see any immediate
problems.

So I've pushed this but split it to add a second patch for the goto fail
thing and attributed it to yourself.

Hope that's OK.


Col



-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/



More information about the pulseaudio-discuss mailing list