[pulseaudio-discuss] [PATCH 8/8] Improve performance of peaks resampler

Colin Guthrie gmane at colin.guthr.ie
Mon Nov 28 03:02:58 PST 2011


'Twas brillig, and Maarten Bosmans at 28/11/11 09:45 did gyre and gimble:
> 2011/11/27 Colin Guthrie <gmane at colin.guthr.ie>:
>> 'Twas brillig, and Maarten Bosmans at 02/11/11 20:54 did gyre and gimble:
>>> This is mainly achieved by special-casing the common 1ch float case,
>>> which is used by applications such as pavucontrol.
>>
>> OK, I pushed this and the previous patch too.
>>
>> I didn't check the maths so I'll trust your analysis here (and the peaks
>> resampler isn't really super important either, hence my slightly
>> lackadaisical stance :D)
> 
> Thanks Colin.
> 
> Unfortunately you pushed an earlier version of the patch. This isn't
> entirely your fault, as these two patches have been floating on the
> list in various versions at 16-11, 2-11 and 14-10 (note to readers
> from the USA: try reversing those numbers ;-) and you picked the
> middle one.
> 
> I rebased the latest patch on master and the diff that remains has
> been sent to the list. It's fairly insignificant by itself, that's why
> I rolled it up in the earlier patches to start with.

Yup, got it now. Sorry about that, and I'll claim responsibility for not
being as responsive as usual on the old patchey-mergey cycle!

Cheers for keeping those eagle eyes open :)

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/



More information about the pulseaudio-discuss mailing list